Plug support #49
Plug support #49
Conversation
8e54b20 to
931945a
Compare
plug CurlReq.PlugThis is now possible |
| fn -> | ||
| conn | ||
| |> CurlReq.Plug.decode() | ||
| |> CurlReq.Curl.encode() |
lib/curl_req/plug.ex
Outdated
| ``` | ||
|
|
||
|
|
||
| Add a filter function |
There was a problem hiding this comment.
I suppose this is the place where people have to do something if they don't want their login requests to be logged.
There was a problem hiding this comment.
Exactly! I will improve the docs to make that clearer and supply some use cases. Also thinking about both types of filtert to either include/reject based on a user defined boolean function. Sometimes you only want to log on a specific route and sometimes you would want to exclude a specific route (you can use the complete conn struct so it doesn't have to be only routes but you can define rules on header or method or whatever)
There was a problem hiding this comment.
@derekkraan i updated the docs with a better example. This filter function already has the ability to allow/reject depending on the way you write you filter logic so i decided against my idea for a filter and reject function
Closes #47
In your Phoenix Controller you can now write something like this: