8000 refactor: id class ObjectId로 변경 by ddingmin · Pull Request #160 · depromeet/depromeet-makers-be · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: id class ObjectId 8000 로 변경 #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2025
Merged

refactor: id class ObjectId로 변경 #160

merged 2 commits into from
Mar 23, 2025

Conversation

ddingmin
Copy link
Member

💡 기능

  • ObjectId로 두고 사용하면 생성 timestamp 등 꺼내서 사용하기 편할 거 같아 지정했습니다.
    • 다만 presentation(swagger)에서는 ObjectId로 두면 문서에서 객체로 보여서 DTO에서는 String 타입을 사용하도록 했습니다.
  • ObjectId를 not null로 두고 애플리케이션 레벨에서 id를 할당하도록 했습니다..!
    • ObjectId 생성 로직이 인스턴스 id랑 타임스탬프 + random 조합이라 중복이슈는 없을 것 같아요.
    • 다만 isNew 로직을 정상적으로 못탈텐데 관련된 작업이 아직은 없어 인지만 하면 좋을 것 같아요.

🔎 기타

@ddingmin ddingmin requested a review from CChuYong as a code owner March 21, 2025 08:44
@ddingmin ddingmin changed the title reafctor: id class ObjectId로 변경 refactor: id class ObjectId로 변경 Mar 21, 2025
CChuYong
CChuYong approved these changes Mar 23, 2025
View reviewed changes
Copy link
Member
@CChuYong CChuYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
신기하군용

@ddingmin ddingmin merged commit d2f4675 into main Mar 23, 2025
2 checks passed
@ddingmin ddingmin deleted the feature/change-memberId branch March 23, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CChuYong C 5340 ChuYong CChuYong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddingmin @CChuYong
0