Add 'hint' to supported severities #4967
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d46acb6 to
2281f3a
Compare
2281f3a to
f0c5086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears (in my naivety about the codebase) to be what is needed to support LSP's "Hint" severity so plugins like vim9-lsp and coc.nvim which optionally feed into ALE's diagnostic system can display the full breadth of severity types in the language server protocol. For example, rust-analyzer uses hints extensively in "two-part" diagnostics (e.g. "... due to this" pointing to a related line). I haven't added tests yet and the documentation could be more complete, thus this is in draft mode: @w0rp Is this something you're interested in supporting? I think it makes a lot of sense; I'm content to complete this if so.
Closes #4899.