Fixed issues with Footer and Webhint #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaYco
suggested changes
Jan 14, 2021
There was a problem hiding this comment.
Changes Requested
Hello! 👋
Awesome job so far!! 👍 you still need to make some changes though!
Required Changes ♻️
- The pull request should be from a feature branch to master/main (screenshot from Pathwright)
also as I side note, please don't use a new PR for each code review, one PR is enough. - Make the PR description more descriptive. (screenshot from Pathwright)
please make the appropriate changes and ask for another code review ✔️
Happy Coding!
Best,
Aziz Mejri
contact me on twitter or slack (@SpaYco) if you need any help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to fix the footer logo which was not loading. Also fixed grammatical errors and web hint errors