8000 test(front-matter): inline test data by timreichen · Pull Request #6465 · denoland/std · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(front-matter): inline test data #6465

Merged
merged 6 commits into from
Mar 12, 2025
Merged

test(front-matter): inline test data #6465

merged 6 commits into from
Mar 12, 2025
+408 −360

Conversation

timreichen
Copy link
Contributor

In preparation to investigate #6464

This PR removes test data abstractions and inlines them. This makes the code more verbose but makes the tests more readable and understandable.

@timreichen timreichen requested a review from kt3k as a code owner March 6, 2025 23:11
@codecov Codecov
Copy link
codecov bot commented Mar 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.69%. Comparing base (d6823ad) to head (b912e1f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6465      +/-   ##
==========================================
- Coverage   95.72%   95.69%   -0.04%     
==========================================
  Files         575      575              
  Lines       43192    43192              
  Branches     6471     6475       +4     
==========================================
- Hits        41344    41331      -13     
- Misses       1815     1822       +7     
- Partials       33       39       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timreichen timreichen changed the title refactor(front_matter): inline tests refactor(front-matter): inline tests Mar 6, 2025
kt3k
kt3k reviewed Mar 10, 2025
View reviewed changes
kt3k
kt3k reviewed Mar 10, 2025
View reviewed changes
kt3k
kt3k approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member
@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the test cases look easier to follow to me. Thanks for the clean ups! LGTM

@kt3k kt3k changed the title refactor(front-matter): inline tests test(front-matter): inline test fixtures Mar 12, 2025
@kt3k kt3k changed the title test(front-matter): inline test fixtures test(front-matter): inline test data Mar 12, 2025
@kt3k kt3k merged commit 75ecea0 into denoland:main Mar 12, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
front-matter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timreichen @kt3k
0