perf(encoding): improve base64 encode/decode performance #6461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6461 +/- ##
==========================================
- Coverage 95.87% 95.86% -0.01%
==========================================
Files 572 572
Lines 42831 42739 -92
Branches 6428 6419 -9
==========================================
- Hits 41065 40973 -92
Misses 1727 1727
Partials 39 39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iuioiua
reviewed
Mar 7, 2025
Comment on lines
+31
to
+34
| const alphabet = new TextEncoder() | ||
| .encode("ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/"); | ||
| const rAlphabet = new Uint8Array(128).fill(64); // alphabet.length | ||
| alphabet.forEach((byte, i) => rAlphabet[byte] = i); |
There was a problem hiding this comment.
This looks like what BidirectionalMap was created for.
There was a problem hiding this comment.
I originally had a Map for the rAlphabet variable but found it noticeably slower to index than a Uint8Array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5944
This pull request brings the performance added in #6457 to the stable base64 and base64url functions, but in a non-breaking manner. The only difference a user would find is a difference in error message if providing an invalid encoded string.