Rough reporting to html too, got the html mocha reporter and put the very very basics #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +28,13 @@ | |||
|
|
|||
| function execKarmaMethod(evt) { | |||
| var msg = evt.data; | |||
| if (msg.command === 'result') { | |||
There was a problem hiding this comment.
As you can see later, there is another check to see if command is complete. Can you refactor this to use a map of commands and actions, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was playing around with the reporter, and just copied the html generation from the mocha reporter, without adding the fancy stuff about suites and so on, but now it shows an scrollable iframe with the result of the tests:
http://gyazo.com/deee8d7381579afe0d8485c07aa1b8b5