8000 feat: Fix find_component_inputs, update unit tests by vblagoje · Pull Request #162 · deepset-ai/canals · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 28, 2023. It is now read-only.

feat: Fix find_component_inputs, update unit tests #162

Merged
merged 1 commit into from
Nov 15, 2023
Merged

feat: Fix find_component_inputs, update unit tests #162

merged 1 commit into from
Nov 15, 2023

Conversation

vblagoje
Copy link
Member
  • Fixes premature merge of feat: Add Component inputs/outputs functions #158
  • I didn't update the branch and rerun unit tests before the merge
  • is_optional field was removed from the canals input socket, causing execution and test failures
  • This PR fixes find_component_inputs to report on is_mandatory and is_variadic fields of an input socket

@vblagoje
Copy link
Member Author

cc @ZanSara @masci @silvanocerza - apologies

@vblagoje vblagoje requested a review from ZanSara November 14, 2023 21:30
masci
masci approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor
@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@masci masci merged commit 379b0ab into main Nov 15, 2023
@masci masci deleted the fix_find_component_inputs branch November 15, 2023 08:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@masci masci masci approved these changes

@ZanSara ZanSara Awaiting requested review from ZanSara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vblagoje @masci
0