This repository was archived by the owner on Nov 28, 2023. It is now read-only.
fix: change is_optional with has_default
#155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is_optional with has_defaultis_optional with has_default
371a24b to
4ba6954
Compare
masci
added a commit
that referenced
this pull request
Nov 14, 2023
* change 6606 is_optional to has_default * do not hardcode defaults * remove deepcopy --------- Co-authored-by: Massimiliano Pippi <mpippi@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for: #105
This PR changes
InputSocket.is_optionalintoInputSocket.has_default. This change affects both the semantic of the field and the behavior of Pipeline.Optionalis no more used to signal that the respective inputs are not to be waited for. Now the way to mark inputs as "not to be waited for" is to give them a default value, irrespective of their type.In short: before, a component that declared:
was signaling the Pipeline that
valueis not to be waited for. Now the way to send the same signal to Pipeline is:where 100 could be any value.
Note: this breaks a lot of tests. Fixing this implies modifications in the
run()method that will be addressed in separate PRs.