8000 client: eth, fix user action resolution handling by norwnd · Pull Request #3178 · decred/dcrdex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

client: eth, fix user action resolution handling #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

client: eth, fix user action resolution handling #3178

merged 1 commit into from
Feb 7, 2025

Conversation

norwnd
Copy link
Contributor
@norwnd norwnd commented Feb 6, 2025

I've noticed UI breaks in the following scenario:

  • Ethereum/Polygon transaction gets stuck
  • user action is requested in UI suggesting to bump transaction fee
  • I didn't do anything about this user action (eventually clicked "keep waiting") but transaction got mined on its own
  • and then UI broke with the following error in console:
image

looking through the relevant code it seems we are requesting action while we should resolve action instead, which is what I've done in this PR

norwnd
norwnd commented Feb 6, 2025
View reviewed changes
client/asset/eth/eth.go
w.requestAction(asset.ActionResolved, pendingTx.ID, nil, pendingTx.TokenID)
w.resolveAction(pendingTx.ID, pendingTx.TokenID)
Copy link
Contributor Author
@norwnd norwnd Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is the root cause of this issue, my understanding is that's just a typo of sorts

because in UI code there is no handler for actionResolved notification - https://github.com/norwnd/bison-lean/blob/a6ebf5f3c01fae0fbb04a819e67b779f24fcb901/client/webserver/site/src/js/app.ts#L643-L655

JoeGruffins
JoeGruffins approved these changes Feb 7, 2025
View reviewed changes
8000 Copy link
Member
@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right. Thank you.

@JoeGruffins JoeGruffins merged commit a2556d1 into decred:master Feb 7, 2025
5 checks passed
martonp pushed a commit to martonp/dcrdex that referenced this pull request Feb 7, 2025
@norwnd @martonp
client: eth, fix user action resolution handling (decred#3178)
6f58a79 
Co-authored-by: norwnd <norwnd>
buck54321 pushed a commit to buck54321/dcrdex that referenced this pull request Feb 25, 2025
@norwnd @buck54321
client: eth, fix user action resolution handling (decred#3178)
56ad743 
Co-authored-by: norwnd <norwnd>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martonp martonp martonp approved these changes

@JoeGruffins JoeGruffins JoeGruffins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norwnd @martonp @JoeGruffins
0