8000 [docs] Fix internalNetworkCIDR vcd docs by trofimovdals · Pull Request #14091 · deckhouse/deckhouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[docs] Fix internalNetworkCIDR vcd docs #14091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

[docs] Fix internalNetworkCIDR vcd docs #14091

merged 2 commits into from
Jun 23, 2025

Conversation

trofimovdals
Copy link
Contributor
@trofimovdals trofimovdals commented Jun 20, 2025

Description

Delete the mention that addresses are allocated starting from 10 from internalNetworkCIDR in vcd cloud-provider

Why do we need it, and what problem does it solve?

This is not valid, and was copied from vsphere

Why do we need it in the patch release (if we do)?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: docs
type: fix
summary: Delete the mention that addresses are allocated starting from 10 from internalNetworkCIDR in vcd cloud-provider
impact_level: low

Signed-off-by: dmitry.trofimov <dmitry.trofimov@falnt.com>
@github-actions github-actions bot added area/cloud-provider Pull requests that update cloud providers modules area/cluster-and-infrastructure Pull requests that update infra modules area/api-change Pull requests that api changing labels Jun 20, 2025
@trofimovdals trofimovdals marked this pull request as ready for review June 20, 2025 09:24
@trofimovdals trofimovdals added this to the v1.70.7 milestone Jun 20, 2025
@Zhbert Zhbert requested a review from MargaretKozlova June 20, 2025 09:33
@Steamvis Steamvis added the status/backport Cherry-pick PR to the release branch from the Milestone label Jun 20, 2025
@MargaretKozlova MargaretKozlova requested review from denmaloyreb and removed request for MargaretKozlova June 20, 2025 12:58
Signed-off-by: Denis.Rebenok <denis.rebenok@flant.ru>
@Steamvis Steamvis modified the milestones: v1.70.7, v1.70.8 Jun 23, 2025
@Zhbert Zhbert merged commit 35d0f99 into main Jun 23, 2025
64 of 66 checks passed
@Zhbert Zhbert deleted the fix-docs-vcd branch June 23, 2025 12:48
github-actions bot pushed a commit that referenced this pull request Jun 23, 2025
* Fix internalNetworkCIDR vcd docs

Signed-off-by: dmitry.trofimov <dmitry.trofimov@falnt.com>

* docs: Synchronize ru and eng cluster_configuration

Signed-off-by: Denis.Rebenok <denis.rebenok@flant.ru>

---------

Signed-off-by: dmitry.trofimov <dmitry.trofimov@falnt.com>
Signed-off-by: Denis.Rebenok <denis.rebenok@flant.ru>
Co-authored-by: dmitry.trofimov <dmitry.trofimov@falnt.com>
Co-authored-by: Denis.Rebenok <denis.rebenok@flant.ru>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the status/backport Cherry-pick PR to the release branch from the Milestone label Jun 23, 2025
deckhouse-BOaTswain added a commit that referenced this pull request Jun 23, 2025
* Fix internalNetworkCIDR vcd docs



* docs: Synchronize ru and eng cluster_configuration



---------

Signed-off-by: dmitry.trofimov <dmitry.trofimov@falnt.com>
Signed-off-by: Denis.Rebenok <denis.rebenok@flant.ru>
Co-authored-by: Dmitry Trofimov <161188690+trofimovdals@users.noreply.github.com>
Co-authored-by: dmitry.trofimov <dmitry.trofimov@falnt.com>
Co-authored-by: Denis.Rebenok <denis.rebenok@flant.ru>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 14122 to the branch release-1.70 successful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api-change Pull requests that api changing area/cloud-provider Pull requests that update cloud providers modules area/cluster-and-infrastructure Pull requests that update infra modules status/backport/success
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0