8000 [user-authn] Add ServiceAccount to templates by YuryLysov · Pull Request #13214 · deckhouse/deckhouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[user-authn] Add ServiceAccount to templates #13214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

[user-authn] Add ServiceAccount to templates #13214

merged 1 commit into from
Apr 25, 2025

Conversation

YuryLysov
Copy link
Contributor
@YuryLysov YuryLysov commented Apr 25, 2025 •
edited
Loading

Description

Add separate ServiceAccount to basic-auth-proxy template

Why do we need it, and what problem does it solve?

According to CIS 5.1.5, default service account should not be used for Kubernetes API access

Why do we need it in the patch release (if we do)?

In v1.69 basic-auth-proxy fails to start, this changes will fix it.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: user-authn
type: fix
summary: Add separate ServiceAccount to basic-auth-proxy.
impact_level: default

@github-actions github-actions bot added the area/auth Pull requests that update auth modules label Apr 25, 2025
@YuryLysov YuryLysov added this to the v1.69.4 milestone Apr 25, 2025
@YuryLysov
Add SA to templates
430b4dc 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@YuryLysov YuryLysov force-pushed the fix/basic-auth-proxy-template branch from f424357 to 430b4dc Compare April 25, 2025 06:52
@github-actions github-actions bot added area/cluster-and-infrastructure Pull requests that update infra modules go Pull requests that update Go code labels Apr 25, 2025
@YuryLysov YuryLysov marked this pull request as ready for review April 25, 2025 07:16
@name212 name212 added the status/backport Cherry-pick PR to the release branch from the Milestone label Apr 25, 2025
@z9r5 z9r5 merged commit 46ebf4b into main Apr 25, 2025
57 of 58 checks passed
@z9r5 z9r5 deleted the fix/basic-auth-proxy-template branch April 25, 2025 09:55
github-actions bot pushed a commit that referenced this pull request Apr 25, 2025
@YuryLysov @z9r5
[user-authn] Add ServiceAccount to templates (#13214)
235b957 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the status/backport Cherry-pick PR to the release branch from the Milestone label Apr 25, 2025
deckhouse-BOaTswain added a commit that referenced this pull request Apr 25, 2025
@deckhouse-BOaTswain @YuryLysov
[user-authn] Add ServiceAccount to templates (#13214) (#13221)
f2954e5 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
Co-authored-by: YuryLysov <yuriy.lysov@flant.com>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 13221 to the branch release-1.69 successful!

@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Apr 25, 2025
Merged
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request May 5, 2025
Merged
Lada7878 pushed a commit that referenced this pull request May 13, 2025
@YuryLysov @Lada7878
[user-authn] Add ServiceAccount to templates (#13214)
797e9cd 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
morhayn pushed a commit that referenced this pull request May 14, 2025
@YuryLysov @morhayn
[user-authn] Add ServiceAccount to templates (#13214)
771625f 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@name212 name212 name212 approved these changes

@nabokihms nabokihms Awaiting requested review from nabokihms nabokihms is a code owner

@sprait sprait Awaiting requested review from sprait sprait is a code owner

Assignees

@YuryLysov YuryLysov

Labels
area/auth Pull requests that update auth modules area/cluster-and-infrastructure Pull requests that update infra modules go Pull requests that update Go code status/backport/success
Projects
None yet
Milestone
v1.69.4
Development

Successfully merging this pull request may close these issues.
4 participants
@YuryLysov @deckhouse-BOaTswain @name212 @z9r5
0