8000 [kube-dns] Change pattern for stubZones to allow _ by saribaev021 · Pull Request #13118 · deckhouse/deckhouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[kube-dns] Change pattern for stubZones to allow _ #13118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

[kube-dns] Change pattern for stubZones to allow _ #13118

merged 1 commit into from
Apr 21, 2025

Conversation

saribaev021
Copy link
Contributor

Description

Make validation pattern for stubZones more widely.

Why do we need it, and what problem does it solve?

Fix #390
Fix #12238
For example, we can setting kube-dns like this:

apiVersion: deckhouse.io/v1alpha1
kind: ModuleConfig
metadata:
  name: kube-dns
spec:
  enabled: true
  settings:
    stubZones:
    - upstreamNameservers:
      - 8.8.8.8
      zone: _acme-challenge.example.com
    upstreamNameservers:
    - 10.128.0.6
  version: 1

Why do we need it in the patch release (if we do)?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: kube-dns
type: fix
summary: Expanded pattern for `stubZones` to allow underscores (`_`) in domain names.
impact_level: default

fix regex pattern
746ced7 
Signed-off-by: Kanatbek Saribaev <kanatbek.saribaev@flant.com>
@saribaev021 saribaev021 added this to the v1.69.3 milestone Apr 21, 2025
@github-actions github-actions bot added area/cluster-and-infrastructure Pull requests that update infra modules area/api-change Pull requests that api changing labels Apr 21, 2025
@z9r5 z9r5 added the skip/documentation-validation Skip documentation validation in pull request label Apr 21, 2025
@z9r5 z9r5 merged commit a453890 into main Apr 21, 2025
56 of 59 checks passed
@z9r5 z9r5 deleted the fix-regex-pattern branch April 21, 2025 11:43
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Apr 21, 2025
Merged
@saribaev021 saribaev021 added the status/backport Cherry-pick PR to the release branch from the Milestone label Apr 21, 2025
github-actions bot pushed a commit that referenced this pull request Apr 21, 2025
@saribaev021
[kube-dns] Change pattern for stubZones to allow '_' (#13118)
2e67de0 
Signed-off-by: Kanatbek Saribaev <kanatbek.saribaev@flant.com>
Co-authored-by: Kanatbek Saribaev <kanatbek.saribaev@flant.com>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the status/backport Cherry-pick PR to the release branch from the Milestone label Apr 21, 2025
deckhouse-BOaTswain added a commit that referenced this pull request Apr 21, 2025
@deckhouse-BOaTswain @saribaev021
[kube-dns] Change pattern for stubZones to allow '_' (#13118) (#13122)
76a8136 
Signed-off-by: Kanatbek Saribaev <kanatbek.saribaev@flant.com>
Co-authored-by: Kanatbek Saribaev <53699219+saribaev021@users.noreply.github.com>
Co-authored-by: Kanatbek Saribaev <kanatbek.saribaev@flant.com>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 13122 to the branch release-1.69 successful!

@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Apr 22, 2025
Merged
morhayn pushed a commit that referenced this pull request May 14, 2025
@saribaev021 @morhayn
[kube-dns] Change pattern for stubZones to allow '_' (#13118)
9f6e14a 
Signed-off-by: Kanatbek Saribaev <kanatbek.saribaev@flant.com>
Co-authored-by: Kanatbek Saribaev <kanatbek.saribaev@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z9r5 z9r5 z9r5 approved these changes

@name212 name212 name212 approved these changes

@nabokihms nabokihms Awaiting requested review from nabokihms nabokihms is a code owner

Assignees

@saribaev021 saribaev021

Labels
area/api-change Pull requests that api changing area/cluster-and-infrastructure Pull requests that update infra modules skip/documentation-validation Skip documentation validation in pull request status/backport/success
Projects
None yet
Milestone
v1.69.3
Development

Successfully merging this pull request may close these issues.

[cert-manager] acme dns01 recursive nameservers
4 participants
@saribaev021 @deckhouse-BOaTswain @z9r5 @name212
0