8000 Relax pyparsing version specifier by ninoseki · Pull Request #840 · decalage2/oletools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Relax pyparsing version specifier #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Relax pyparsing version specifier #840

wants to merge 1 commit into from

Conversation

ninoseki
Copy link
Contributor

Relax pyparsing version specifier to allow using pyparsing v3.

Background

I want to use oletools with a library which specifically requires pyparsing v3+. More specifically, this one.

v2-v3 Compatibility

v3 starts using snake_case API (e.g. add_parse_action) but it preserves camelCase API. So, as far as I checked, it's safe to use v3 with the current usage. (Ref. https://pyparsing-docs.readthedocs.io/en/latest/whats_new_in_3_0_0.html#api-changes)

@decalage2 decalage2 self-requested a review February 13, 2024 10:43
@decalage2 decalage2 self-assigned this Feb 13, 2024
@decalage2 decalage2 added this to the oletools 0.60 milestone Feb 13, 2024
@ninoseki
Copy link
Contributor Author
ninoseki commented Mar 3, 2024

I'm sorry. I realized this PR is duplicated with #812. So let me close this PR.

@ninoseki ninoseki closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decalage2 decalage2 Awaiting requested review from decalage2

Assignees

@decalage2 decalage2

Labels
olevba 👍 enhancement
Projects
None yet
Milestone
oletools 0.60
Development

Successfully merging this pull request may close these issues.
2 participants
@ninoseki @decalage2
0