8000 fix: allow status code 429 for linkspector by stasadev · Pull Request #7270 · ddev/ddev · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

fix: allow status code 429 for linkspector #7270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

fix: allow status code 429 for linkspector #7270

merged 2 commits into from
May 6, 2025

Conversation

stasadev
Copy link
Member
@stasadev stasadev commented May 6, 2025 •
edited
Loading

The Issue

We get 429 from GitHub links for linkspector https://github.com/ddev/ddev/actions/runs/14861937842/attempts/2

It seems that GitHub changed some limits.

How This PR Solves The Issue

I noticed that we use GITHUB_TOKEN for actions (this is not the env itself, it's name for custom action variable) instead of github_token (IDE highlighted it for me)

Adds an exception for 429 status.

Manual Testing Instructions

Automated Testing Overview

Release/Deployment Notes

@stasadev stasadev requested a review from a team as a code owner May 6, 2025 15:11
@stasadev
Copy link
Member Author
stasadev commented May 6, 2025

I got the same error in https://github.com/ddev-test/ddev/actions/runs/14863320774/job/41733676200

@stasadev stasadev changed the title fix: use github_token for linkspector fix: allow status code 429 for linkspector May 6, 2025
@stasadev
Copy link
Member Author
stasadev commented May 6, 2025

Success with 429 status allowed in https://github.com/ddev-test/ddev/actions/runs/14863503281/job/41734319606

rfay
rfay approved these changes May 6, 2025
View reviewed changes
Copy link
Member
@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should do this for now.

@github-actions github-actions bot added the bugfix label May 6, 2025
@rfay rfay merged commit 001530a into ddev:main May 6, 2025
12 checks passed
@rfay rfay deleted the 20250506_stasadev_linkspector branch May 6, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stasadev @rfay
0