8000 feat: add success message for xhgui on and off, fixes #7202 by rpkoller · Pull Request #7205 · ddev/ddev · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add success message for xhgui on and off, fixes #7202 #7205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 24, 2025
Merged

feat: add success message for xhgui on and off, fixes #7202 #7205

merged 6 commits into from
Apr 24, 2025

Conversation

rpkoller
Copy link
Collaborator

The Issue

How This PR Solves The Issue

Manual Testing Instructions

Automated Testing Overview

Release/Deployment Notes

@rpkoller rpkoller requested a review from a team as a code owner April 12, 2025 21:18
@rpkoller
Copy link
Collaborator Author

the only odd thing, on the test file, i've just added the two asserts at the end but on save the head was changed automatically. not sure why and more importantly if correct :/

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 12, 2025 •
edited
Loading

Download the artifacts for this pull request:

See Testing a PR.

Open in GitHub Codespaces

sreichel
sreichel reviewed Apr 12, 2025
View reviewed changes
sreichel
sreichel reviewed Apr 12, 2025
View reviewed changes
rfay
rfay requested changes Apr 12, 2025
View reviewed changes
Copy link
Member
@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions.

I have no idea why the annotation in auth-ssh_test.go is showing up.

@rpkoller rpkoller force-pushed the 20250412-rpkoller-xhgui-status branch from 3484a08 to e3a8ea7 Compare April 14, 2025 14:51
@rpkoller rpkoller force-pushed the 20250412-rpkoller-xhgui-status branch from e3a8ea7 to 421ea3f Compare April 24, 2025 04:14
rfay
rfay approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member
@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution, thanks!

@rfay rfay merged commit ed441d7 into ddev:main Apr 24, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel left review comments

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpkoller @rfay @sreichel
0