feat: override PAGER with DDEV_PAGER env variable, for #6842
#6900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasadev
commented
Jan 15, 2025
| @@ -71,7 +71,7 @@ services: | |||
| - POSTGRES_PASSWORD=db | |||
| - POSTGRES_USER=db | |||
| - POSTGRES_DB=db | |||
| - PAGER=less -SFX | |||
| - PAGER=${DDEV_PAGER-less -SFX} | |||
There was a problem hiding this comment.
This is intentional syntax; the below syntax will not work for an empty string: export DDEV_PAGER=, because it will use the default less -SFX instead of an empty string:
Suggested change
| - PAGER=${DDEV_PAGER-less -SFX} | |
| - PAGER=${DDEV_PAGER:-less -SFX} # this will not work as expected |
|
Download the artifacts for this pull request:
See Testing a PR. |
a5f32f4 to
c4f0897
Compare
It's a good question. We do have other things that can probably be overridden, but DDEV is usually overriding them. |
rfay
approved these changes
Jan 15, 2025
Yes, let's use with-pager for now, otherwise we won't get any feedback. |
|
You'd get feedback from @tyler36 ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
We don't have a quick and easy way to override
PAGERvariable in thewebanddbcontainers.How This PR Solves The Issue
Adds an optional environment variable
DDEV_PAGER.I'm unsure where to add information about DDEV_PAGER in the docs (should we?).
The section on Environment Variables Provided is not the right place, as it covers variables inside the container, whereas
DDEV_PAGERis used outside the container.Manual Testing Instructions
Automated Testing Overview
Release/Deployment Notes