build: push gitpod and codespaces images/packages during release #6613
Conversation
|
Download the artifacts for this pull request:
See Testing a PR. |
|
730cb8b to
b1fa1ff
Compare
036adf2 to
608a00d
Compare
|
OK, ready for your review. That turned out to be a lot more than a Sunday afternoon excursion :) |
|
|
||
| VERSION := $(shell git describe --tags --always --dirty) | ||
|
|
||
| .PHONY: build clean test | ||
|
|
||
| CURRENT_ARCH=$(shell ../get_arch.sh) | ||
|
|
||
| # This Makefile explicitly does not include containers/containers_shared.mak, | ||
| # This Makefile explicitly does not include containers/containers_shared.mk, |
There was a problem hiding this comment.
I see test build error for ddev-dbserver:
./build_image.sh: line 123: DOCkER_ORG: unbound variable
build_image.sh needs to pass DOCKER_ORG inside:
ddev/containers/ddev-dbserver/Makefile
Lines 63 to 67 in aeb5ee0
There was a problem hiding this comment.
Working on that, fails locally too.
|
|
||
| - name: Replace version in devcontainer-feature.json | ||
| run: | | ||
| sed -i 's/\${DDEV_VERSION}/'"${GITHUB_REF##*/}"'/g' ./containers/devcontainers/install-ddev/devcontainer-feature.json |
There was a problem hiding this comment.
${GITHUB_REF##*/} looks the same as ${GITHUB_REF_NAME} from https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables
Edit:
Oh, GITHUB_REF_NAME for PRs: <pr_number>/merge, so the variable needs to be modified anyway.
Okay, it doesn't matter in this case, ignore my comment.
| github: | ||
| prebuilds: | ||
| # enable for the master/default branch (defaults to true) | ||
| master: true | ||
| # enable for all branches in this repo (defaults to false) | ||
| branches: true | ||
| # enable for pull requests coming from this repo (defaults to true) | ||
| pullRequests: true | ||
| # enable for pull requests coming from forks (defaults to false) | ||
| pullRequestsFromForks: true | ||
| # add a check to pull requests (defaults to true) | ||
| addCheck: true | ||
| # add a "Review in Gitpod" button as a comment to pull requests (defaults to false) | ||
| addComment: false | ||
| # add a "Review in Gitpod" button to the pull request's description (defaults to false) | ||
| addBadge: true | ||
| # add a label once the prebuild is ready to pull requests (defaults to false) | ||
| addLabel: true | ||
|
|
There was a problem hiding this comment.
Is this config not needed? I want to understand why we remove it.
Okay I see
Deprecated: Filtering prebuilds via the .gitpod.yml is deprecated.
| RUN for item in golang.org/x/tools/gopls@latest github.com/go-delve/delve/cmd/dlv@latest; do \ | ||
| go install $item; \ | ||
| done |
There was a problem hiding this comment.
We should have go clean -modcache here in the same RUN, because go install downloads cache to ~/go/pkg, and it's not removed.
There was a problem hiding this comment.
I wish we'd had this conversation earlier, I might have gotten out of the trouble I was in. I was really surprised about how this popped up when it didn't seem to have been there before. Perhaps upstream changed. Think it's sorted now.
|
Hard to believe I could get so lost and destabilize so many things in an afternoon journey, but I think it's going now, https://github.com/ddev-test/ddev/releases/tag/v1.23.5-aaa-testgitpod.22 and https://github.com/ddev-test/ddev/actions/runs/11357139682 Please take another look and we'll see where we get. The reality is that many image Makefiles changed, and by rights new images should be pushed. But we're about to do that. So it would be easier to pull this, push the new images, run the tests. |
The Issue
We've had the gitpod image and codespaces package pushes as separate tasks for some time, and they weren't always done.
How This PR Solves The Issue
latesttag for Docker images for stable releases. We don't need to use these, and probably shouldn't, but this will remove maintenance of ddev-gitpod-launcher, and may help with how things work for drupalpod eventually. There is a place forlatestNotes
I was overly ambitious here and tried to create a multi-architecture image of the upstream gitpod base image. That attempt was removed in 608a00d because it didn't seem to work quite right. I was trying to recreate the gitpod-sourced image with an alternate build technique, not using their
dazzletechnique. It didn't seem to me that it was working completely correctly, and I think my proposed use of the arm64 image was probably not as useful as expected.Manual Testing Instructions