8000 Use ReadPassword to read token. by janisz · Pull Request #1551 · dcos/dcos-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use ReadPassword to read token. #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2020
Merged

Use ReadPassword to read token. #1551

merged 1 commit into from
Aug 19, 2020

Conversation

janisz
Copy link
Contributor
@janisz janisz commented Aug 17, 2020 •
edited
Loading

Currently we are using simple Input to read token. Due to some limitation and echoing it will be better to read it as password.

ReadConsole does not read more than 254 bytes when ENABLE_LINE_INPUT is enabled.

Refs: golang/go#36071
Fixes: https://jira.d2iq.com/browse/COPS-6421

@janisz
Use ReadPassword to read token.
112dd73 
Currently we are using simple Input to read token.
Due to some limitation adn echoing it will be better to read
it as password.

> ReadConsole does not read more than 254 bytes when ENABLE_LINE_INPUT is
enabled.

Refs: golang/go#36071
pierrebeitz
pierrebeitz approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor
@pierrebeitz pierrebeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable!

@janisz janisz merged commit d5e4a0b into dcos:master Aug 19, 2020
@janisz janisz deleted the read_whole_token branch August 19, 2020 10:32
6736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrebeitz pierrebeitz pierrebeitz approved these changes

@DominikDary DominikDary Awaiting requested review from DominikDary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janisz @pierrebeitz
0