10000 Accept ACS token passed in env to auth login by janisz · Pull Request #1550 · dcos/dcos-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Accept ACS token passed in env to auth login #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2020
Merged

Accept ACS token passed in env to auth login #1550

merged 2 commits into from
Aug 19, 2020

Conversation

janisz
Copy link
Contributor
@janisz janisz commented Aug 14, 2020 •
edited
Loading

dcos cluster setup accepts ACS token set in DCOS_CLUSTER_SETUP_ACS_TOKEN
environment variable. This PR will add the same behavior to dcos auth login.

Fixes: https://jira.d2iq.com/browse/COPS-6421

@janisz janisz force-pushed the accept_acs_token_passed_with_env branch from 110b848 to d49312e Compare August 14, 2020 13:16
pierrebeitz
pierrebeitz previously approved these changes Aug 14, 2020
View reviewed changes
@janisz janisz force-pushed the accept_acs_token_passed_with_env branch from c3bffb8 to d49312e Compare August 17, 2020 13:28
@janisz
Accept ACS token passed in env to auth login
76fdc5f 
dcos cluster setup accepts ACS Toekn set in DCOS_CLUSTER_SETUP_ACS_TOKEN
environment variable. This PR will add the same behaviour to auth login.

Fixes: https://jira.d2iq.com/browse/COPS-6421
@janisz janisz force-pushed the accept_acs_token_passed_with_env branch from d49312e to 76fdc5f Compare August 17, 2020 13:50
@janisz janisz requested a review from pierrebeitz August 19, 2020 12:38
pierrebeitz
pierrebeitz approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor
@pierrebeitz pierrebeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@janisz janisz merged commit 3d94c54 into dcos:master Aug 19, 2020
@janisz janisz deleted the accept_acs_token_passed_with_env branch August 19, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrebeitz pierrebeitz pierrebeitz approved these changes

@DominikDary DominikDary Awaiting requested review from DominikDary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janisz @pierrebeitz
0