Rewrite Cosmos binary resource URLs when needed #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12ce577 to
ef8ef26
Compare
armandgrillet
suggested changes
Apr 5, 2018
python/lib/dcos/dcos/subcommand.py
Outdated
| DC/OS cluster but uses the wrong scheme. Ideally this "hack" will be | ||
| removed in the future. | ||
|
|
||
| For more context, see https://jira.mesosphere.com/browse/COPS-3052. |
There was a problem hiding this comment.
We should not mention a private ticket in a public repo. Updating DCOS_OSS-2325 to add more context and of this comment line to give a public link would be enough.
Depending on the user setup, they might contain an incorrect scheme. This is because Cosmos relies in the scheme used to query admin router. If a CLI is configured to use HTTPS but a load balancer sits in front of admin router and does TLS termination, these URLs will use the HTTP scheme. Not only that it is a security concern, it would simply fail on setups which don't support HTTPS. This is hopefully a temporary fix until we come-up with a long-term fix in DC/OS. Fixes dcos#1190 https://jira.mesosphere.com/browse/COPS-3052 https://jira.mesosphere.com/browse/DCOS_OSS-2325
Closed
benclarkwood
approved these changes
Apr 5, 2018
armandgrillet
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the user setup, they might contain an incorrect scheme.
This is because Cosmos relies in the scheme used to query admin router.
If a CLI is configured to use HTTPS but a load balancer sits in front
of admin router and does TLS termination, these URLs will use the HTTP
scheme.
Not only that it is a security concern, it would simply fail on setups
which don't support HTTPS. This is hopefully a temporary fix until we
come-up with a long-term fix in DC/OS.
Fixes #1190
https://jira.mesosphere.com/browse/COPS-3052
https://jira.mesosphere.com/browse/DCOS_OSS-2325