Improve output from metrics summary #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were calculating the percentage as free space / total space. We should instead calculate it as used space / total space.
bamarni
reviewed
Jan 11, 2018
cli/dcoscli/metrics.py
Outdated
| @@ -125,7 +127,7 @@ def _node_summary_data(datapoints): | |||
| disk_free = _get_datapoint_value( | |||
| datapoints, 'filesystem.capacity.used', {'path': '/'}) | |||
There was a problem hiding this comment.
the variable is called disk_free while it seems to be disk_used (filesystem.capacity.used).
| @@ -98,6 +98,8 @@ def _node_summary_json(datapoints): | |||
| summary_datapoints = [ | |||
| _get_datapoint(datapoints, 'cpu.total'), | |||
| _get_datapoint(datapoints, 'memory.total'), | |||
| _get_datapoint(datapoints, 'memory.free'), | |||
There was a problem hiding this comment.
here for consistency, could we have memory.used? A few lines below there is filesystem.capacity.used. So that'd make datapoint pairs of used and total.
There was a problem hiding this comment.
Hey @bamarni I do agree that this would make more sense! Unfortunately memory.used isn't available in our stats - we only have memory.free.
|
@bamarni any 8000 other comments or can we start the CI on this one? |
|
run linux integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, as an outcome of
dcos node metrics summary, the CLI reported the percentage of the disk that was available, eg 1GB (99%) for a 100GB disk.This PR updates that calculation so we now see the used percentage, so in the above case the user would now see a disk entry of 1GB (1%).
Additionally, I expanded the output from the --json endpoint after noticing that it only reported the total system memory and disk usage.