Add command for task metrics #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62f5e9e to
e24d82a
Compare
tamarrow-zz
reviewed
Mar 16, 2017
cli/dcoscli/task/main.py
Outdated
| """ | ||
|
|
||
| master = mesos.get_master() | ||
| slave_id = master.task(task_id)['slave_id'] |
There was a problem hiding this comment.
what if there are no slaves?
There was a problem hiding this comment.
I've added a guard for this, but I don't think a Mesos task object can ever not have a slave_id field.
|
Looks great. Is there a structure to the tags or can they be anything? |
|
Tags are arbitrary stringified key, value pairs. |
b24cd2f to
187e75e
Compare
tamarrow-zz
approved these changes
Mar 16, 2017
1d5b4d2 to
cdcbf82
Compare
mesosphere-backup/dcos-metrics#77 updated various keys for the task metrics API.
Add some sugar to avoid constant null-checks for datapoint values.
Integration tests require a one-minute pause and hence are not practicable.
be34148 to
ee237b8
Compare
The task metrics collector runs every minute, meaning that it did not reliably provide data to the integration tests. This could be fixed by adding a force-collection endpoint to tasks, but in the meantime these tests have been replaced with unit test.
klueska
pushed a commit
that referenced
this pull request
Jul 20, 2017
klueska
pushed a commit
that referenced
this pull request
Jul 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
dcos task metricscommand.Components:
dcos task metrics details/appendpointdcos task metrics summarydcos task metrics detailsExample usage:
$ dcos task metrics details app-name.abc123-456789 --json [ { "name": "cpus.user.time", "tags": {...}, "timestamp": "2017-03-15T21:01:46.188487097Z", "unit": "seconds", "value": 0.14 }, ... { "name": "statsd_tester.time.uptime", "timestamp": "2017-03-15T21:02:40Z", "unit": "", "value": 11672303.0 } ]$ dcos task metrics summary app-name.abc123-456789 --json [ { "timestamp": "2017-03-15T21:03:46.221983351Z", "unit": "seconds", "value": 0.14, "name": "cpus.user.time", "tags": {...} 8000 }, { "timestamp": "2017-03-15T21:03:46.221983351Z", "unit": "bytes", "value": 9080832, "name": "mem.total", "tags": {...} }, { "timestamp": "2017-03-15T21:03:46.221983351Z", "unit": "bytes", "value": 0, "name": "disk.used", "tags": {...} } ]