Fix mate sequence when reading sam/bam #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously upon reading the case of tid == mtid was detected and the sequence name mapped to "=". This causes missing sequence name errors upon decompression. As the case of tid == mtid is handled during writing of sam/bam, this patch simply records the full mate sequence name, resolving the matching issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously upon reading the case of tid == mtid was detected and the
sequence name mapped to "=". This causes missing sequence name errors
upon decompression. As the case of tid == mtid is handled during writing
of sam/bam, this patch simply records the full mate sequence name,
resolving the matching issues.
Example read after decompression pre patch:
and post patch: