8000 Fix no budget suggestion when "Fractional Shares" option is selected by mattiapitossi · Pull Request #216 · dcapal/dcapal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix no budget suggestion when "Fractional Shares" option is selected #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 10, 2023
Merged

Fix no budget suggestion when "Fractional Shares" option is selected #216

merged 4 commits into from
Dec 10, 2023

Conversation

mattiapitossi
Copy link
Collaborator
@mattiapitossi mattiapitossi commented Dec 9, 2023 •
edited
Loading

The issue should now be solved:

Screen.Recording.2023-12-09.at.14.43.57.mov

@mattiapitossi mattiapitossi added the A-frontend Area: frontend label Dec 9, 2023
@mattiapitossi mattiapitossi self-assigned this Dec 9, 2023
leonardoarcari
leonardoarcari requested changes Dec 9, 2023
View reviewed changes
Copy link
Collaborator
@leonardoarcari leonardoarcari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also add useWholeShares to the useEffect dependency list in order to trigger suggestion refresh on Use fractional shares toggle

@leonardoarcari leonardoarcari linked an issue Dec 9, 2023 that may be closed by this pull request
Closed
@leonardoarcari leonardoarcari added this to the v0.6.0 milestone Dec 9, 2023
leonardoarcari
leonardoarcari requested changes Dec 10, 2023
View reviewed changes
@mattiapitossi @leonardoarcari
Update dcapal-frontend/src/components/allocationFlow/steps/invest.js
0e48bb9 
Co-authored-by: Leonardo Arcari <leonardo1.arcari@gmail.com>
@leonardoarcari leonardoarcari changed the title Fix issue reported in 205 Fix issue reported in #205 Dec 10, 2023
@leonardoarcari leonardoarcari changed the title Fix issue reported in #205 Fix no budget suggestion when "Fractional Shares" option is selected Dec 10, 2023
@leonardoarcari leonardoarcari merged commit f16c930 into dcapal:master Dec 10, 2023
@mattiapitossi mattiapitossi deleted the 205-bug-no-budget-suggestion-when-fractional-shares-option-is-selected branc 7F4A h July 20, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardoarcari leonardoarcari leonardoarcari approved these changes

@corradopetrelli corradopetrelli Awaiting requested review from corradopetrelli

@KristianLentino99 KristianLentino99 Awaiting requested review from KristianLentino99

Assignees

@mattiapitossi mattiapitossi

Labels
A-frontend Area: frontend
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

[Bug]: No budget suggestion when "Fractional Shares" option is selected
2 participants
@mattiapitossi @leonardoarcari
0