Format Lines: Fix line merging #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merging provider and detection lines, some boxes may be missing, but the layout check fails. This catches and merges in these boxes too.
|
This could use a test |
Avoid slight cutting off of the layout boxes
In format lines mode, we include lines from surya which were not present in the provider lines. However, we do not have ordering of these relative to the provider lines. This commit identifies blocks which contain lines from both sources, and sort with a different method within those blocks (Unchanged for all other blocks)
When merging multiple detected lines into a single provider line, skip detected lines which have already been asigned to a different provider line Was causing repeated text otherwise
Ensure expansion doesn't cut into other layout blocks, still upper bounded by the max fraction
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may have detected text that is not covered by any provider line. We ideally don't want to lose out on these lines in
format_linesmodel. This arises in two cases - One off lines, and when the layout check fails. This PR:Fixes bugs in line merging
pdftextprovider lineAdds an initial implementation for box expansion to avoid picture/figure blocks being cut off
Updates README to remove deprecated
--languagesflag