-
Notifications
You must be signed in to change notification settings - Fork 17
Add Schema validation #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
de5a054
to
c6f2868
Compare
jakemac53
reviewed
May 13, 2025
5e6404f
to
0464ec4
Compare
0464ec4
to
6e4d572
Compare
jakemac53
reviewed
May 19, 2025
jakemac53
approved these changes
May 19, 2025
fe04a01
to
2fbe4fe
Compare
Okay, this is ready to be committed once the tests pass. I added one more minor change after you approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds schema validation to the MCP Schema extension so that we can validate the returned values in tests. It could also be used to validate results from LLMs and make them try again if they don't match the schema.
Also moved the tests into subdirs matching the lib structure.
Tests