8000 convert unnecessary `.from`s to `.of`s by pq · Pull Request #3577 · dart-archive/linter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

convert unnecessary .froms to .ofs #3577

Merged
merged 1 commit into from
Aug 3, 2022
Merged

convert unnecessary .froms to .ofs #3577

merged 1 commit into from
Aug 3, 2022

Conversation

pq
Copy link
Contributor
@pq pq commented Aug 3, 2022

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.625% when pulling d9ee15c on from_to_of into 86f88fa on main.

Copy link
Contributor
@bwilkerson bwilkerson 8000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just removed some good tests for a possible future lint, but otherwise looks good.

@pq pq merged commit 024e8a1 into main Aug 3, 2022
@pq
Copy link
Contributor Author
pq commented Aug 3, 2022

You just removed some good tests for a possible future lint

I'm hoping the link-backs will help keep that history handy!

@pq pq deleted the from_to_of branch August 3, 2022 18:29
Copy link
Contributor
@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

pq added a commit that referenced this pull request Aug 8, 2022
pq added a commit that referenced this pull request Aug 8, 2022
* 1.27.0

* Insert reasoning for `avoid_function_literals_in_foreach_calls` lint (#3545)

* Update avoid_function_literals_in_foreach_calls.dart

* Second attempt

* Add a the to make for betterer english

* convert unnecessary `.from`s to `.of`s (#3577)

* deflake `avoid_redundant_argument_values`

* ++

Co-authored-by: Brett Morgan <brett.morgan@gmail.com>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
* 1.27.0

* Insert reasoning for `avoid_function_literals_in_foreach_calls` lint (dart-archive/linter#3545)

* Update avoid_function_literals_in_foreach_calls.dart

* Second attempt

* Add a the to make for betterer english

* convert unnecessary `.from`s to `.of`s (dart-archive/linter#3577)

* deflake `avoid_redundant_argument_values`

* ++

Co-authored-by: Brett Morgan <brett.morgan@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0