This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Ignore '$' in identifiers; we use in generated code. #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, missed something. I'll fix up and rebase. EDIT: Got it, forgot to update |
|
lgtm |
|
👍 Awesome! |
pq
added a commit
that referenced
this pull request
Sep 5, 2016
* Fixed false positive on `[]=` in `always_declare_return_types` (#300). * New `invariant_booleans` lint. * New `literal_only_boolean_expressions` lint. * Fixed `camel_case_types` to allow `$` in identifiers (#290). BUG= R=alexeidiaz@google.com Review URL: https://codereview.chromium.org//2309313002 .
matanlurey
added a commit
that referenced
this pull request
Oct 7, 2016
I missed a couple of use cases with #290. This covers any rule that uses `identifier` or `lowerCamelCase` RegExp checks, including: - constant_identifier_names - non_constant_identifier_names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: dart-lang/sdk#57363
I am not yet terribly familiar with all of the lints, but I think I modified the two lints (and added simple test cases) that we would run into. Both
camel_case_types,constant_identifier_names, andnon_constant_identifier_namesshould allow the$` character in between case changes.i.e., now valid:
camel_case_types:Foo$Barconstant_identifier_namesandnon_constant_identifier_names:foo$Bar