8000 drop conflicting __version__ by 1ace · Pull Request #4 · darrenburns/dunk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

drop conflicting __version__ #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2022
Merged

drop conflicting __version__ #4

merged 2 commits into from
Apr 4, 2022

Conversation

1ace
Copy link
Contributor
@1ace 1ace commented Apr 4, 2022 
>>> from importlib.metadata import version
>>> version('dunk')
'0.2.0a0'
>>> import dunk
>>> dunk.__version__
'0.1.0'

Let's remove the copy of this information that needs to be manually updated 🙂

@darrenburns darrenburns merged commit 190405f into darrenburns:master Apr 4, 2022
@1ace 1ace deleted the patch-2 branch April 4, 2022 17:43
@1ace
Copy link
Contributor Author
1ace commented Apr 23, 2022

@darrenburns I see you've added this back in ed0cf62?
It's your project, obviously you can do as you please, but I'm just surprised that you accepted this PR but then went back on it.

If you disagree with a PR someone send to your project, you should feel free to tell them "thanks for your contribution, but I don't want to do things this way" or similar; you're in charge 😉

On the other hand, if this was added by accident (eg. by a pre-python3.7 tool), this can be a ping for you to notice this was mistakenly added back 🙂

@darrenburns
Copy link
Owner
darrenburns commented Apr 23, 2022 •
edited
Loading

When I accepted your PR, __version__ was an unused variable so it made sense at the time.

It was added automatically by poetry, and I just hadn't deleted it yet.

The newer versions of dunk now display the version, so it needed to be added back.

The reason I don't use importlib.metadata is it's a 3.8+ feature, and dunk (currently) supports 3.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1ace @darrenburns
0