-
Notifications
You must be signed in to change notification settings - Fork 5
{{ message }}
Make the auto-unmuting of facebook reel videos an optional feature #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, great job, thanks!! I'll check this out more thoroughly tomorrow. |
|
so, uh, are you interested in looking at this or not? |
|
Haha oh dear, totally forgot about this. I’ll merge this later this evening
and put an update.
…On Sat, 10 May 2025 at 21:26, David Goldstein ***@***.***> wrote:
*dgoldstein0* left a comment (darajava/reel-control#10)
<#10 (comment)>
so, uh, are you interested in looking at this or not?
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNCOBOIULQGM43PMGDKDHL25ZOJBAVCNFSM6AAAAAB3AWWDTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNRZGE2DEMBUGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
in review with google, thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, this extension modifies facebook reel videos to always been unmuted; this is contrary to the default facebook behavior and as they auto-play in some parts of the facebook website, I find it quite annoying that they autoplay with audio when this extension is installed. So I made that behavior opt-in through the pop up associated with the extension. (I could also be convinced to change it to be opt-out, but then it's probably worth mentioning in the README of the project - as IMO the extension should advertise the major behavior changes it makes).
Fixes #7