[1.15] Update dapr/kit & diagridio/go-etcd-cron #8687
8000
Jump to bottom
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates dapr/kit => v0.15.2 & diagridio/go-etcd-cron => v0.6.1 The go-etcd-cron update removes a rare deadlock that can occur in Scheduler after running a high throughput under daprd scale events. Also increases Scheduler throughput performance by ~3x. Updates go to 1.24.2 Updates golangci-lint to 1.64.6 Signed-off-by: joshvanl <me@joshvanl.dev>
3dc46cd to
3d77152
Compare
Signed-off-by: joshvanl <me@joshvanl.dev>
yaron2
approved these changes
Apr 28, 2025
| @@ -29,7 +29,7 @@ import ( | |||
| ) | |||
|
|
|||
| func Test_HaltAll(t *testing.T) { | |||
| queue := queue.NewProcessor[string, targets.Idlable](nil) | |||
| queue := queue.NewProcessor[string, targets.Idlable](queue.Options[string, targets.Idlable]{}) | |||
There was a problem hiding this comment.
nit: I just noticed, might be wrong about the spelling, didn't find the definition in the dictionary, but I feel like the word should be: Idleable - something that can be made idle.
There was a problem hiding this comment.
Yes you're correct- but I think best not to change that now in this PR for a backport.
cicoyle
approved these changes
Apr 28, 2025
antontroshin
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates dapr/kit => v0.15.2 & diagridio/go-etcd-cron => v0.6.1
The go-etcd-cron update removes a rare deadlock that can occur in Scheduler after running a high throughput under daprd scale events. Also increases Scheduler throughput performance by ~3x.