10000 Implement ufuncs and gufunc for array-expr by phofl · Pull Request #11818 · dask/dask · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement ufuncs and gufunc for array-expr #11818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Apr 23, 2025
Merged

Implement ufuncs and gufunc for array-expr #11818

merged 34 commits into from
Apr 23, 2025

Conversation

phofl
Copy link
Collaborator
@phofl phofl commented Mar 7, 2025
  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

This adds support for ufuncs and gufunc and passes all tests

phofl added 30 commits January 21, 2025 14:57
@phofl
Disentangle core expression class from dataframe specific code
e57f0bd
@phofl
Disentangle core expression class from dataframe specific code
15f2000
@phofl
Disentangle core expression class from dataframe specific code
4c18a49
@phofl
Disentangle core expression class from dataframe specific code
1dc7da2
@phofl
Merge remote-tracking branch 'upstream/main' into array-expr
7063501
@phofl
Ignore array expr from doctest
2ecba62
@phofl
Fixup
29d009c
@phofl
Clean up some stuf
55997e8
@phofl
Add test job
8e8de72
@phofl
Add test job
683da49
@phofl
Fix skip
1ea3df1
@phofl
Fixup skips
7e82fa6
@phofl
Fixup stuff
f028401
@phofl
Fixup stuff
eedde5e
@phofl
Fixup stuff
f8ef258
@phofl
Debug
85dd863
@phofl
Debug
d8ba6e3
@phofl
Fixup
e068d8c
@phofl
Fixup
f64b4ee
@phofl
Fixup
b6882b4
@phofl
Fixup
b574d71
@phofl
Fixup
c8396f8
@phofl
Implement unify_chunks and Rechunk
6c82200
@phofl
Implement reductions
c7084fe
@phofl
Implement from_array
d3c195a
@phofl
Implement slicing stuff
342ada8
@phofl
Ufunc stuff
a5b01f3
@phofl
Continue ufunc
ca6bd9c
@phofl
Finish gufunc
4215ebe
@phofl
Implement ufuncs and gufunc for array-expr
8d15714
@phofl phofl mentioned this pull request Mar 7, 2025
Open
3 tasks
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 7, 2025 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

      9 files  ±0        9 suites  ±0   3h 19m 32s ⏱️ + 3m 37s
 18 010 tests ±0   16 796 ✅ ±0   1 214 💤 ±0  0 ❌ ±0 
161 164 runs  ±0  149 058 ✅  - 2  12 106 💤 +2  0 ❌ ±0 

Results for commit 4f279bb. ± Comparison against base commit 913026f.

♻️ This comment has been updated with latest results.

@mrocklin
Copy link
Member
mrocklin commented Mar 7, 2025

Cool

a-holm
a-holm reviewed Mar 30, 2025
View reviewed changes
@a-holm
Copy link
a-holm commented Mar 30, 2025

Would be great if the PR description could be expanded to detail which ufuncs/gufuncs are now supported, mention the known limitations (like the numba issues causing xfails), and explicitly state whether new tests were added or if only existing tests were adapted.

Would also be cool if you added module-level docstrings to _gufunc.py and _ufunc.py explaining their purpose. Add docstrings to key classes like ufunc, GUfuncLeafExpr, and potentially complex functions like apply_gufunc. Explain the minor changes in _blockwise.py, _expr.py, and _io.py in the PR description or code comments. Explain the name parameter added to from_array. The logic for handling gufunc signatures, axes, broadcasting, and potential vectorization is inherently complex.

Also the xfail markers in test_gufunc.py. Are these acceptable known limitations, or will they be fixed?

@fjetter fjetter merged commit ef66102 into dask:main Apr 23, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-holm a-holm a-holm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phofl @mrocklin @a-holm @fjetter
0