Ensure concat optimize project does not raise #11784
Conversation
| self.axis, | ||
| self.ignore_unknown_divisions, | ||
| self.interleave_partitions, | ||
| self._kwargs, | ||
| *frames, |
There was a problem hiding this comment.
Ordering was a bit messed up here as well. I attempted to pass the arguments here using keywords but that doesn't work. Our paramters parsing logic isn't smart enough and doesn't capture the frames properly but instead raises a cryptic error message
There was a problem hiding this comment.
Yep, this positional thing is a hack to pass a variable number of expressions….
8000
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 9 files ± 0 9 suites ±0 3h 31m 3s ⏱️ -30s Results for commit 7871448. ± Comparison against base commit 06c1bb7. |
Our way of subclassing isn't working well. The subclasses can not/should not define a different set of paramters since otherwise all logic on the base class will just break. In this case it can be provoked by adding a projection after an optimize call