8000 Added `flaky` to tests extra by TomAugspurger · Pull Request #11770 · dask/dask · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added flaky to tests extra #11770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

Added flaky to tests extra #11770

merged 1 commit into from
Feb 21, 2025

Conversation

TomAugspurger
Copy link
Member

I believe this is the package that provides the flaky mark / fixture we use in a few spots (e.g.

dask/dask/bytes/tests/test_http.py

Line 194 in f2b8287

@pytest.mark.flaky(
).

@TomAugspurger
Added flaky to tests extra
43d3609 
I believe this is the package that provides the `flaky` mark / fixture
we use in a few spots.
@phofl phofl merged commit dad1b91 into dask:main Feb 21, 2025
28 checks passed
@phofl
Copy link
Collaborator
phofl commented Feb 21, 2025

thanks

@TomAugspurger
Copy link
Member Author

Sorry, I just noticed this might be the wrong plugin, or I messed something up with the install:

ERROR dask/array/tests/test_cupy_core.py::test_setitem_extended_API_2d[index13-value13] - TypeError: _FlakyPlugin._make_test_flaky() got an unexpected keyword argument 'reruns'

I'll follow up in a bit.

@TomAugspurger
Copy link
Member Author

I think it's actually https://pypi.org/project/pytest-rerunfailures/, spotted in https://github.com/dask/distributed/blob/cb4aa079446de1aa0463859f52c1b127594b643e/distributed/pytest_resourceleaks.py#L36. I'll make another PR.

TomAugspurger added a commit to TomAugspurger/dask that referenced this pull request Feb 21, 2025
@TomAugspurger
Remove flaky optional dependency
f605596 
This reverts dask#11770. The `flaky`
mark comes from a different package, pytest-rerunfailures,
which is already present.
@TomAugspurger TomAugspurger mentioned this pull request Feb 21, 2025
Merged
@TomAugspurger TomAugspurger deleted the tom/fix/flaky-optional branch February 21, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAugspurger @phofl
0