8000 Rename remote store to FsspecStore by phofl · Pull Request #11660 · dask/dask · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rename remote store to FsspecStore #11660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

Rename remote store to FsspecStore #11660

merged 1 commit into from
Jan 10, 2025

Conversation

phofl
Copy link
Collaborator
@phofl phofl commented Jan 10, 2025

@phofl phofl added the upstream label Jan 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   4h 34m 7s ⏱️ + 6m 21s
 17 153 tests ±0   15 958 ✅ ±0   1 195 💤 ±0  0 ❌ ±0 
211 329 runs  ±0  194 152 ✅ ±0  17 177 💤 ±0  0 ❌ ±0 

Results for commit 7693068. ± Comparison against base commit 7f97e68.

@fjetter fjetter mentioned this pull request Jan 10, 2025
Closed
8 tasks
hendrikmakait
hendrikmakait approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member
@hendrikmakait hendrikmakait left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @phofl! I assume CI hasn't complained because it hasn't yet picked up zarr==3.0.0?

@phofl
Copy link
Collaborator Author
phofl commented Jan 10, 2025

Yeah that's what I assumed too

@phofl phofl merged commit 2df9ed3 into dask:main Jan 10, 2025
25 of 27 checks passed
@phofl phofl deleted the zarr-v3 branch January 10, 2025 15:50
@will-moore
Copy link

Thanks for the update.
I just tried this change locally, and now I'm seeing:

TypeError: FsspecStore.__init__() got an unexpected keyword argument 'mode'

@will-moore
Copy link

There's one other zarr.storage.RemoteStore() in the same file at https://github.com/phofl/dask/blob/76930685dae941bca7686df50814d190a5b55a13/dask/array/core.py#L3751C17-L3751C71

@phofl
Copy link
Collaborator Author
phofl commented Jan 13, 2025

Thanks! I should really be less trusting, looks like our test coverage sucks

@phofl
Copy link
Collaborator Author
phofl commented Jan 13, 2025 •
edited
Loading

#11668

@will-moore will-moore mentioned this pull request Jan 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmakait hendrikmakait hendrikmakait approved these changes

Assignees
No one assigned
Labels
upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zarr.storage.RemoteStore renamed
3 participants
@phofl @will-moore @hendrikmakait
0