8000 Fixed mypy config by TomAugspurger · Pull Request #11651 · dask/dask · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed mypy config #11651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fixed mypy config #11651

merged 1 commit into from
Jan 9, 2025

Conversation

TomAugspurger
Copy link
Member
@TomAugspurger TomAugspurger commented Jan 8, 2025 •
edited
Loading

I noticed that the pyproject.toml had a couple invalid mypy configuration settings. I've updated the two to use the correct name, and flipped the setting so that the intent should be the same (e.g. allow_untyped_defs=false should be disallow_untyped_defs=true).

https://mypy.readthedocs.io/en/stable/config_file.html has the valid settings.

Pre-commit is passing, and I think mypy runs in pre-commit, so it seems like things were compatible with these settings anyway.

(distributed might need a similar PR. I'll get to that later)

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 8, 2025

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  +     1       15 suites  +1   4h 27m 14s ⏱️ + 18m 59s
 17 162 tests +     5   15 967 ✅ ±     0   1 195 💤 +    5  0 ❌ ±0 
211 463 runs  +16 232  194 283 ✅ +14 826  17 180 💤 +1 406  0 ❌ ±0 

Results for commit 3483e06. ± Comparison against base commit 7393a77.

@TomAugspurger
Copy link
Member Author

The CI failure looks transient:

Create environment: python=3.11 numpy
error    libmamba Error when extracting package: Could not chdir info/recipe/parent/yum_requirements.txt
Found incorrect download: libgfortran. Aborting

I can't rerun that job: https://github.com/dask/dask/actions/runs/12680331849/job/35341884904?pr=11651. Maybe someone can do that for me.

phofl
phofl approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator
@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the tests started failing non-deterministically 2 days ago, we can ignore that.

@phofl phofl merged commit ee1c2b4 into dask:main Jan 9, 2025
27 of 28 checks passed
@phofl
Copy link
Collaborator
phofl commented Jan 9, 2025

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAugspurger @phofl
0