8000 Avoid constructing `NestedContainer`s in case of trivial inputs by hendrikmakait · Pull Request #11600 · dask/dask · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Avoid constructing NestedContainers in case of trivial inputs #11600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 17, 2024
Merged

Avoid constructing NestedContainers in case of trivial inputs #11600

merged 3 commits into from
Dec 17, 2024

Conversation

hendrikmakait
Copy link
Member

I noticed this while debugging dask/distributed#8959

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

jrbourbeau
jrbourbeau reviewed Dec 13, 2024
View reviewed changes
Copy link
Member
@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hendrikmakait. The mypy error looks related

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Dec 13, 2024 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±  0       15 suites  ±0   3h 59m 20s ⏱️ - 1m 43s
 13 275 tests +  8   12 213 ✅ +  8   1 062 💤 ±0  0 ❌ ±0 
164 721 runs  +120  141 792 ✅ +118  22 929 💤 +2  0 ❌ ±0 

Results for commit e0e7594. ± Comparison against base commit 24c4920.

♻️ This comment has been updated with latest results.

@jrbourbeau jrbourbeau mentioned this pull request Dec 13, 2024
Closed
7 tasks
@hendrikmakait
Copy link
Member Author

@jrbourbeau: Fixed the mypy problem

@phofl phofl merged commit e95f0f2 into dask:main Dec 17, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

@jrbourbeau jrbourbeau Awaiting requested review from jrbourbeau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hendrikmakait @jrbourbeau @phofl
0