8000 fix: make getKeyChainType public by HashEngineering · Pull Request #217 · dashpay/dashj · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: make getKeyChainType public #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 21, 2023
Merged

fix: make getKeyChainType public #217

merged 4 commits into from
Jun 21, 2023

Conversation

HashEngineering
Copy link
Collaborator

Issue being fixed or feature implemented

make on function public

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@HashEngineering HashEngineering requested a review from Syn-McJ June 11, 2023 00:48
@HashEngineering HashEngineering self-assigned this Jun 11, 2023
@HashEngineering HashEngineering mentioned this pull request Jun 11, 2023
Merged
3 tasks
Syn-McJ
Syn-McJ requested changes Jun 11, 2023
View reviewed changes
Copy link
Member
@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HashEngineering looks good, however, we also need to access AuthenticationKeyChainGroup from AuthenticationGroupExtension somehow. This method probably also needs to be public:

@Override
protected AnyKeyChainGroup getKeyChainGroup() {
    return keyChainGroup;
}

@HashEngineering
Copy link
Collaborator Author

@HashEngineering looks good, however, we also need to access AuthenticationKeyChainGroup from AuthenticationGroupExtension somehow. This method probably also needs to be public:

@Override
protected AnyKeyChainGroup getKeyChainGroup() {
    return keyChainGroup;
}

It is now public

@HashEngineering HashEngineering requested a review from Syn-McJ June 11, 2023 20:45
@HashEngineering HashEngineering force-pushed the bugfix-getkeychaintype branch from 3db6426 to 568a336 Compare June 11, 2023 20:46
Syn-McJ
Syn-McJ approved these changes Jun 12, 2023
8000
View reviewed changes
Copy link
Member
@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HashEngineering HashEngineering mentioned this pull request Jun 14, 2023
Merged
3 tasks
@HashEngineering HashEngineering force-pushed the bugfix-getkeychaintype branch from 3613b56 to fdc378f Compare June 20, 2023 15:56
@codecov
Copy link
codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 65.60% and project coverage change: +0.29 🎉

Comparison is base (6cc07b6) 48.01% compared to head (fc66198) 48.30%.

Additional details and impacted files 
@@                  Coverage Diff                   @@
##             feature-coinjoin     #217      +/-   ##
======================================================
+ Coverage               48.01%   48.30%   +0.29%     
- Complexity               7113     7188      +75     
======================================================
  Files                     449      449              
  Lines                   49378    49406      +28     
  Branches                 7041     7040       -1     
======================================================
+ Hits                    23707    23866     +159     
+ Misses                  22923    22799     -124     
+ Partials                 2748     2741       -7
Impacted Files Coverage Δ
core/src/main/java/org/bitcoinj/core/Context.java 62.66% <0.00%> (+5.71%) ⬆️
core/src/main/java/org/bitcoinj/core/Message.java 74.83% <0.00%> (+0.83%) ⬆️
...main/java/org/bitcoinj/core/PeerSocketHandler.java 48.38% <ø> (-3.23%) ⬇️
...rc/main/java/org/bitcoinj/core/VersionMessage.java 59.23% <ø> (ø)
...itcoinj/evolution/MasternodeListDiffException.java 0.00% <0.00%> (ø)
.../main/java/org/bitcoinj/evolution/QuorumState.java 49.41% <0.00%> (-0.89%) ⬇️
...itcoinj/wallet/AbstractKeyChainGroupExtension.java 58.22% <ø> (ø)
...g/bitcoinj/wallet/AuthenticationKeyChainGroup.java 22.38% <ø> (ø)
...in/java/org/bitcoinj/wallet/CoinJoinExtension.java 48.38% <ø> (ø)
core/src/main/java/org/bitcoinj/wallet/Wallet.java 71.82% <0.00%> (-0.18%) ⬇️
... and 18 more

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HashEngineering HashEngineering merged commit 7adfe0c into feature-coinjoin Jun 21, 2023
@HashEngineering HashEngineering deleted the bugfix-getkeychaintype branch August 18, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syn-McJ Syn-McJ Syn-McJ approved these changes

Assignees

@HashEngineering HashEngineering

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HashEngineering @Syn-McJ
0