Feature support hpmn #210
Merged
Feature support hpmn #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
============================================
+ Coverage 46.80% 46.84% +0.03%
- Complexity 6383 6388 +5
============================================
Files 408 408
Lines 45854 45860 +6
Branches 6486 6486
============================================
+ Hits 21464 21483 +19
+ Misses 21997 21986 -11
+ Partials 2393 2391 -2
☔ View full report in Codecov by Sentry. |
Syn-McJ
approved these changes
May 17, 2023
| "35.82.49.196", | ||
| "44.232.196.6", | ||
| "54.189.164.39", | ||
| "54.213.204.85", | ||
| }; | ||
|
8000
|
||
| @Override | ||
| public String[] getDefaultMasternodeList() { | ||
| return MASTERNODES; |
There was a problem hiding this comment.
Shouldn't this return a combined list of MASTERNODES + HP_MASTERNODES? I assumed hp-masternodes can still be used for all the regular functions.
There was a problem hiding this comment.
Yes, you are right, I was probably thinking that these lists can be combined but didn't add any code to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Add HPMN's to network parameters.
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only