feat(coinjoin): support encrypted wallets #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* include tests for these methods
* fix: NPE's
* previous action was to stop CoinJoin
HashEngineering
commented
Feb 21, 2023
Comment on lines
+17
to
+23
| package org.bitcoinj.coinjoin.callbacks; | ||
|
|
||
| import org.bitcoinj.core.ECKey; | ||
|
|
||
| public interface RequestDecryptedKey { | ||
| ECKey requestDecryptedKey(ECKey encryptedKey); | ||
| } |
There was a problem hiding this comment.
This call will decrypt a single key.
HashEngineering
commented
Feb 21, 2023
Comment on lines
+17
to
+24
| package org.bitcoinj.coinjoin.callbacks; | ||
|
|
||
| import org.bitcoinj.wallet.Wallet; | ||
| import org.bouncycastle.crypto.params.KeyParameter; | ||
|
|
||
| public interface RequestKeyParameter { | ||
| KeyParameter requestKeyParameter(Wallet wallet); | ||
| } |
There was a problem hiding this comment.
This call back will obtain the key parameter (encryption key) for the wallet. used with SendRequests.
HashEngineering
commented
Feb 21, 2023
Comment on lines
+328
to
+343
|
|
||
| public void setRequestKeyParameter(RequestKeyParameter requestKeyParameter) { | ||
| this.requestKeyParameter = requestKeyParameter; | ||
| } | ||
|
|
||
| public void setRequestDecryptedKey(RequestDecryptedKey requestDecryptedKey) { | ||
| this.requestDecryptedKey = requestDecryptedKey; | ||
| } | ||
|
|
||
| public @Nullable KeyParameter requestKeyParameter(WalletEx mixingWallet) { | ||
| return requestKeyParameter != null ? requestKeyParameter.requestKeyParameter(mixingWallet) : null; | ||
| } | ||
|
|
||
| public @Nullable ECKey requestDecryptKey(ECKey key) { | ||
| return requestDecryptedKey != null ? requestDecryptedKey.requestDecryptedKey(key) : null; | ||
| } |
There was a problem hiding this comment.
CoinJoinManager will keep track of the callbacks.
There was a problem hiding this comment.
In DashPay, we will use these functions like this:
interface CoinJoinService {
fun configureMixing(
amount: Coin,
requestKeyParameter: RequestKeyParameter,
requestDecryptedKey: RequestDecryptedKey
)
} if (blockchainIdentityData.creationState <= CreationState.MIXING_FUNDS) {
platformRepo.updateIdentityCreationState(blockchainIdentityData, CreationState.MIXING_FUNDS)
coinJoinService.configureMixing(
Constants.DASH_PAY_FEE,
{ encryptionKey },
{ it.decrypt(encryptionKey) })
coinJoinService.prepareAndStartMixing()
coinJoinService.waitForMixing();
}|
There is a problem with one of the tests due to a Context mismatch on Linux and not Mac. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only