8000 fix: coinjoin sending by HashEngineering · Pull Request #194 · dashpay/dashj · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: coinjoin sending #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 9, 2023
Merged

fix: coinjoin sending #194

merged 3 commits into from
Feb 9, 2023

Conversation

HashEngineering
Copy link
Collaborator

Issue being fixed or feature implemented

Fix CoinJoinCoinSelector

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@HashEngineering HashEngineering self-assigned this Feb 8, 2023
@codecov
Copy link
codecov bot commented Feb 8, 2023 •
edited
Loading

Codecov Report

Base: 46.45% // Head: 46.42% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (62a5d56) compared to base (476f800).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@                  Coverage Diff                   @@
##             feature-coinjoin     #194      +/-   ##
======================================================
- Coverage               46.45%   46.42%   -0.03%     
- Complexity               6088     6089       +1     
======================================================
  Files                     423      423              
  Lines                   45181    45191      +10     
  Branches                 6294     6299       +5     
======================================================
- Hits                    20987    20982       -5     
- Misses                  21864    21881      +17     
+ Partials                 2330     2328       -2
Impacted Files Coverage Δ
...va/org/bitcoinj/coinjoin/CoinJoinCoinSelector.java 33.33% <0.00%> (-5.13%) ⬇️
.../java/org/bitcoinj/wallet/DefaultCoinSelector.java 97.50% <ø> (ø)
core/src/main/java/org/bitcoinj/wallet/Wallet.java 68.38% <0.00%> (-0.17%) ⬇️
...main/java/org/bitcoinj/core/PeerSocketHandler.java 51.08% <0.00%> (-7.61%) ⬇️
...src/main/java/org/bitcoinj/net/BlockingClient.java 75.86% <0.00%> (-6.90%) ⬇️
...e/src/main/java/org/bitcoinj/core/BloomFilter.java 73.97% <0.00%> (-1.37%) ⬇️
...c/main/java/org/bitcoinj/net/NioClientManager.java 61.95% <0.00%> (-1.09%) ⬇️
core/src/main/java/org/bitcoinj/script/Script.java 84.31% <0.00%> (-0.13%) ⬇️
...a/org/bitcoinj/coinjoin/CoinJoinClientSession.java 45.61% <0.00%> (+0.12%) ⬆️
...rg/bitcoinj/store/LevelDBFullPrunedBlockStore.java 62.48% <0.00%> (+0.15%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HashEngineering HashEngineering marked this pull request as ready for review February 8, 2023 02:49
This was referenced Feb 8, 2023
Merged
Merged
Merged
< 8000 div class="">
Syn-McJ
Syn-McJ approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member
@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HashEngineering HashEngineering merged commit 53faef1 into feature-coinjoin Feb 9, 2023
@HashEngineering HashEngineering deleted the fix-coinjoin-sending branch April 21, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syn-McJ Syn-McJ Syn-McJ approved these changes

Assignees

@HashEngineering HashEngineering

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HashEngineering @Syn-McJ
0