feat: cores iap #4449
feat: cores iap #4449
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
| if (isIOSNative()) { | ||
| return iOSSupportsCoresPurchase(); |
There was a problem hiding this comment.
This means we are not going to allow purchases through web with apple (in-app browser to be specific). Although it is more of an edge case. Should we maybe not check anymore since we will support both Paddle and iap with iPhone products?
There was a problem hiding this comment.
I am fine with both, probably just to check with product.
There was a problem hiding this comment.
Cool. I'll send a message. Just to be sure we won't get into any legal trouble.
| @@ -0,0 +1,103 @@ | |||
| import type { | |||
There was a problem hiding this comment.
Moved some common interfaces/functions here.
| }; | ||
|
|
||
| const getApplePlusPricing = (metadata: ProductPricingMetadata[]) => |
There was a problem hiding this comment.
Took the liberty to refactor and reuse these code blocks to the new file.
| @@ -19,20 +21,12 @@ const AWARD_TYPES = { | |||
| } as const; | |||
| export type AwardTypes = keyof typeof AWARD_TYPES; | |||
|
|
|||
| const SCREENS = { | |||
There was a problem hiding this comment.
Duplicate. We have another one which contains more items.
There was a problem hiding this comment.
I am not sure if it is duplicate, since different context should have limited number of different screens, at least thats how Chris and I imagined it?
There was a problem hiding this comment.
Oh. Thought they were duplicates. I can return it back, maybe I'll adjust the naming to avoid confusion.
There was a problem hiding this comment.
yeah that would work
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://cores-iap.preview.app.daily.dev