8000 contract: pay: support bridging with across by andrewliu08 · Pull Request #1353 · daimo-eth/daimo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

contract: pay: support bridging with across #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Oct 17, 2024
Merged

contract: pay: support bridging with across #1353

merged 19 commits into from
Oct 17, 2024

Conversation

andrewliu08
Copy link
Member

No description provided.

@vercel Vercel
Copy link
vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daimo-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 4:44am
daimo-web-stage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 4:44am

@dcposch dcposch mentioned this pull request Oct 8, 2024
Closed
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
packages/contract/src/interfaces/IDaimoPayBridger.sol
import "openzeppelin-contracts/contracts/token/ERC20/IERC20.sol";

/// @notice Bridges assets automatically. Specifically, it lets any market maker
/// initiate a bridge transaction to another chain.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
packages/contract/src/pay/DaimoPay.sol Outdated
Comment on lines 92 to 98
function addressToBytes32(address addr) internal pure returns (bytes32) {
return bytes32(uint256(uint160(addr)));
}

function bytes32ToAddress(bytes32 b) internal pure returns (address) {
return address(uint160(uint256(b)));
}
Copy link
Member
@dcposch dcposch Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently specific to CCTP
can delete here

potentially, we can move these to IDaimoPayBridger.sol & generalize that interface to allow 32-byte addresses. this would let us support intents where the destination is eg. on solana, or intents where someone's paying from solana etc

dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
packages/contract/src/pay/DaimoPay.sol
intentAddr: address(intentContract),
finalRecipient: recipient,
intent: intent
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
dcposch
dcposch approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member
@dcposch dcposch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGreatTM after comments

Left to do ~

  • Across decision
  • DaimoPayLP testing
  • Test deployment on mainnet base+op+linea

@andrewliu08 andrewliu08 force-pushed the andrew/pay-contracts branch from 23ea94d to 576fe76 Compare October 9, 2024 23:31
@dcposch dcposch changed the title pay contract: New Daimo Pay contracts to support bridging with across contract: pay: support bridging with across Oct 17, 2024
andrewliu08 and others added 18 commits October 16, 2024 21:28
@andrewliu08 andrewliu08 merged commit 9057a17 into internal Oct 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcposch dcposch dcposch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewliu08 @dcposch
0