fix: support repeat policy for nested DAGs #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying dagu-doc with
|
| Latest commit: |
3b93a0a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f2ec08fe.dagu-doc.pages.dev |
| Branch Preview URL: | https://fix-repeat-policy.dagu-doc.pages.dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
==========================================
+ Coverage 65.83% 67.68% +1.84%
==========================================
Files 93 93
Lines 13785 13840 +55
==========================================
+ Hits 9076 9368 +292
+ Misses 3926 3672 -254
- Partials 783 800 +17
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #1013 where RepeatPolicy did not work properly with nested DAGs (sub-workflows). The bug caused repeated runs to fail after the first execution, with sub-workflows remaining in "not started" status and creating zombie processes.
Changes
repeatedflag toGenerateChildDAGRunID()that includes randomness when generating IDs for repeated nested DAG runs, preventing ID collisionsRepeatedfield toNodeStateto identify when a step is being repeatedlimitfield in RepeatPolicy to cap the maximum number of executionsWhy
The root cause was that repeated nested DAG runs were generating the same run ID on subsequent executions, causing conflicts in the execution tracking system. By adding randomness to the run ID generation for repeated steps, each execution gets a unique identifier, allowing proper tracking and preventing zombie processes.
The addition of the repeat limit feature provides users with better control over long-running repeat policies, preventing infinite loops and resource exhaustion.
Reported-by: jeremydelattre59
Github-Issue: #1013