8000 Use same request ID for sub-DAG retries by yottahmd · Pull Request #911 · dagu-org/dagu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use same request ID for sub-DAG retries #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 29, 2025
Merged

Use same request ID for sub-DAG retries #911

merged 11 commits into from
Apr 29, 2025

Conversation

yottahmd
Copy link
Collaborator

No description provided.

@yottahmd yottahmd changed the title WIP: Use same request ID for sub-DAG retries Use same request ID for sub-DAG retries Apr 29, 2025
@yottahmd yottahmd merged commit b3866c4 into dev-v1.17.0 Apr 29, 2025
4 checks passed
@yottahmd yottahmd deleted the reuse-reqid-retry-subrun branch April 29, 2025 02:39
@codecov Codecov
Copy link
codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 54.71698% with 120 lines in your changes missing coverage. Please review.

Project coverage is 59.03%. Comparing base (5ba0026) to head (94d5d2b).
Report is 1 commits behind head on dev-v1.17.0.

Files with missing lines Patch % Lines
internal/cmd/start.go 39.62% 26 Missing and 6 partials ⚠️
internal/cmd/context.go 57.14% 12 Missing and 6 partials ⚠️
internal/digraph/scheduler/data.go 15.78% 16 Missing ⚠️
internal/persistence/jsondb/jsondb.go 60.52% 11 Missing and 4 partials ⚠️
internal/digraph/loader.go 33.33% 14 Missing ⚠️
internal/persistence/jsondb/run.go 73.17% 8 Missing and 3 partials ⚠️
internal/digraph/scheduler/node.go 0.00% 5 Missing and 1 partial ⚠️
internal/cmd/retry.go 80.00% 4 Missing and 1 partial ⚠️
internal/persistence/node.go 0.00% 2 Missing ⚠️
internal/agent/agent.go 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           dev-v1.17.0     #911      +/-   ##
===============================================
- Coverage        59.23%   59.03%   -0.20%     
===============================================
  Files               73       73              
  Lines             8257     8386     +129     
===============================================
+ Hits              4891     4951      +60     
- Misses            2909     2967      +58     
- Partials           457      468      +11
Files with missing lines Coverage Δ
internal/cmd/dry.go 73.75% <100.00%> (+0.33%) ⬆️
internal/cmd/restart.go 57.85% <100.00%> (+0.30%) ⬆️
internal/config/loader.go 87.86% <100.00%> (-0.04%) ⬇️
internal/digraph/builder.go 59.15% <100.00%> (+0.34%) ⬆️
internal/digraph/func.go 14.28% <ø> (ø)
internal/digraph/step.go 91.66% <ø> (ø)
internal/persistence/jsondb/dataroot.go 59.88% <100.00%> (+1.17%) ⬆️
internal/persistence/local/dagstore.go 0.00% <ø> (ø)
internal/agent/agent.go 56.89% <66.66%> (-0.95%) ⬇️
internal/persistence/node.go 23.72% <0.00%> (-0.84%) ⬇️
... and 8 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba0026...94d5d2b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This was referenced Apr 29, 2025
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yottahmd
0