8000 [#785] persistence: feat: refactor history data structure to save DAG information by yottahmd · Pull Request #868 · dagu-org/dagu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[#785] persistence: feat: refactor history data structure to save DAG information #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 63 commits into from
Mar 17, 2025
Merged

[#785] persistence: feat: refactor history data structure to save DAG information #868

merged 63 commits into from
Mar 17, 2025

Conversation

yottahmd
Copy link
Collaborator

Issue: #785

@yottahmd yottahmd force-pushed the 786-refactor-persistence branch from dbff7dd to 1d0b644 Compare February 28, 2025 11:57
@yottahmd
refactor writer
594eed4
@yottahmd
refactor
113e618
@yottahmd
refactor
2128498
@yottahmd
refactor context handling
7d1144f
@yottahmd
refactor
22cbd02
@yottahmd
refactor
3a56526
@yottahmd
refactor
2353497
@yottahmd
add .aider to gitignore
2f98b52
@yottahmd
refactor
75ac4b5
@yottahmd
refactor
9e2d4c7
@yottahmd
refactor
f89c0af
@yottahmd
feat: Add metrics tracking and logging for DAG execution performance
7d56a80
@yottahmd
Based on the changes you've made, here's a concise commit message tha…
9f5bdfa 
…t captures the essence of the improvements:

feat: Add comprehensive metrics collection to scheduler
@yottahmd
feat: Add total nodes metric initialization in scheduler
5deed37
@yottahmd
feat: Add node execution time tracking and metrics collection
e7f5d11
@yottahmd
refactor
e4f9f20
@yottahmd
refactor
3b5d7ee
@yottahmd
refactor
38b6046
@yottahmd
refactor jsondb
b30a4aa
@yottahmd
refactor
0b349f8
@yottahmd
refactor: separate jsondb function into historydata.go
64fd82d
@yottahmd
add cline rule 10000
15ae7e3
@yottahmd
rename jsondb to historyStore
c6de79d
@yottahmd yottahmd changed the base branch from main to dev-v1.7.0 March 17, 2025 03:34
@yottahmd yottahmd changed the title [#785] persistence: feat: support concurrent execution of the same DAG [#785] persistence: feat: refactor history data structure to save DAG information Mar 17, 2025
@yottahmd yottahmd marked this pull request as ready for review March 17, 2025 07:24
@yottahmd yottahmd merged commit 97bd415 into dev-v1.7.0 Mar 17, 2025
7 checks passed
@yottahmd yottahmd deleted the 786-refactor-persistence branch March 17, 2025 07:27
@codecov Codecov
Copy link
codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 63.36422% with 514 lines in your changes missing coverage. Please review.

Project coverage is 56.56%. Comparing base (23fa1cb) to head (9914c52).
Report is 1 commits behind head on dev-v1.7.0.

Files with missing lines Patch % Lines
internal/persistence/jsondb/record.go 61.15% 69 Missing and 25 partials ⚠️
internal/agent/agent.go 39.36% 47 Missing and 10 partials ⚠️
internal/digraph/exec.go 27.84% 57 Missing ⚠️
internal/persistence/jsondb/writer.go 50.00% 25 Missing and 12 partials ⚠️
internal/persistence/jsondb/storage/storage.go 82.52% 25 Missing and 11 partials ⚠️
internal/digraph/scheduler/scheduler.go 77.12% 35 Missing ⚠️
internal/persistence/jsondb/jsondb.go 65.30% 29 Missing and 5 partials ⚠️
internal/client/client.go 60.78% 18 Missing and 2 partials ⚠️
internal/digraph/context.go 6.25% 15 Missing ⚠️
internal/digraph/dag.go 25.00% 14 Missing and 1 partial ⚠️
... and 17 more
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           dev-v1.7.0     #868      +/-   ##
==============================================
+ Coverage       56.02%   56.56%   +0.54%     
==============================================
  Files              75       78       +3     
  Lines            8195     8700     +505     
==============================================
+ Hits             4591     4921     +330     
- Misses           3218     3375     +157     
- Partials          386      404      +18
Files with missing lines Coverage Δ
internal/client/interface.go 100.00% <ø> (ø)
internal/cmd/context.go 75.31% <100.00%> (+1.70%) ⬆️
internal/cmd/start.go 66.66% <100.00%> (ø)
internal/cmd/status.go 62.50% <100.00%> (ø)
internal/config/loader.go 88.00% <100.00%> (+0.03%) ⬆️
internal/digraph/builder.go 58.77% <100.00%> (+0.43%) ⬆️
internal/digraph/executor/mail.go 32.75% <100.00%> (ø)
internal/digraph/executor/ssh.go 35.13% <100.00%> (-0.58%) ⬇️
internal/digraph/loader.go 63.80% <100.00%> (-0.66%) ⬇️
internal/digraph/template.go 28.00% <ø> (ø)
... and 31 more

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23fa1cb...9914c52. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yottahmd yottahmd mentioned this pull request Mar 17, 2025
Closed
This was referenced Apr 25, 2025
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yottahmd
0