8000 Fix linter error by rafiramadhana · Pull Request #515 · dagu-org/dagu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix linter error #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2024
Merged

Fix linter error #515

merged 1 commit into from
Jan 1, 2024

Conversation

rafiramadhana
Copy link
Contributor
@rafiramadhana rafiramadhana commented Jan 1, 2024 •
edited
Loading

Fix error when running make go-lint

➜  dagu git:(main) ✗ make go-lint
service/frontend/middleware/basic_auth_test.go:14:10: Error return value of `w.Write` is not checked (errcheck)
		w.Write([]byte("OK"))
		       ^
make: *** [Makefile:83: go-lint] Error 1

This error affects make build, so I think it is quite important to fix this

@yottahmd yottahmd added the bug Something isn't working label Jan 1, 2024
@codecov Codecov
Copy link
codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22f3138) 73.11% compared to head (ee08c95) 72.84%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   73.11%   72.84%   -0.27%     
==========================================
  Files          43       43              
  Lines        3678     3705      +27     
==========================================
+ Hits         2689     2699      +10     
- Misses        850      868      +18     
+ Partials      139      138       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yottahmd
Copy link
Collaborator
yottahmd commented Jan 1, 2024

Thank you so much!

@yottahmd yottahmd merged commit 41ca155 into dagu-org:main Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafiramadhana @yottahmd
0