10000 [BUG] Sub workflows seems to work not anymore · Issue #846 · dagu-org/dagu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUG] Sub workflows seems to work not anymore #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Daffdi opened this issue Feb 18, 2025 · 2 comments
Closed

[BUG] Sub workflows seems to work not anymore #846

Daffdi opened this issue Feb 18, 2025 · 2 comments
Assignees
@yottahmd
Milestone
v1.16.3

Comments

@Daffdi
Copy link
Daffdi commented Feb 18, 2025 •
edited
Loading

We want to use dagu at our company and have to use a lot of sub workflows. Unfortunately the sub workflow process seems to be "broken".

If i use a simple sub workflow configuration, the following error appeared in the web ui log:

Error: unknown flag: --requestID
Usage:
  dagu start [flags] /path/to/spec.yaml [-- params1 params2]

Flags:
  -c, --config string   config file (default is $HOME/.config/dagu/config.yaml)
  -h, --help            help for start
  -p, --params string   parameters to pass to the DAG
  -q, --quiet           suppress output
  -r, --req string      request ID for the DAG execution

If i understand the go code correctly, the issue arised with the change
https://github.com/dagu-org/dagu/pull/834/files#diff-e3ad76770e5ac8ed654e8c5585782469e67e0d981adb9153604109263f22e93eR47

The sub flow go code seems to use the old requestID param:

dagu/internal/digraph/executor/sub.go

Line 65 in 3618023

fmt.Sprintf("--requestID=%s", requestID),

Thx in advance
@yottahmd
Copy link
Collaborator

@Daffdi Thank you for reporting this issue! Sorry for the inconvenience, I'll fix this ASAP.

@yottahmd yottahmd self-assigned this Feb 18, 2025
@yottahmd yottahmd modified the milestones: Backlog, v1.16.3 Feb 18, 2025
@yottahmd yottahmd mentioned this issue Feb 18, 2025
Merged
yottahmd added a commit that referenced this issue Feb 18, 2025
@yottahmd
[#846] Fix: issue in calling sub-DAG (#848)
6db86b9
@yottahmd
Copy link
Collaborator

It's fixed in v1.16.3. Thanks again for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yottahmd yottahmd

Labels
None yet
Projects
None yet
Milestone
v1.16.3
Development

No branches or pull requests
2 participants
@yottahmd @Daffdi
0