make label types generic #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drive-by comment: Can you use this as a return type perhaps, or does that break things? setDefaultNodeLabel(
label: NodeLabel,
): this; |
Good idea, changed the return types to |
|
Ok, I now realize why so many lines of whitespace were in the patch last time. You've accidentally replaced spaces with tabs. |
I fixed it now, thanks for reminding me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes graph label, node label and edge label types generic which results in better type safety when creating and getting nodes and so on.
This is also more inline with the graphlib types that dagre exposes.
The generics default to
any, so this is completely backwards compatible.